Skip to content

VR: dnsmasq does not listen on 127.0.0.1#10440

Closed
weizhouapache wants to merge 1 commit intoapache:4.19from
weizhouapache:4.19-fix-shared-network-dhcp-leases
Closed

VR: dnsmasq does not listen on 127.0.0.1#10440
weizhouapache wants to merge 1 commit intoapache:4.19from
weizhouapache:4.19-fix-shared-network-dhcp-leases

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Feb 21, 2025 •
edited
Loading

Description

This PR fixes #10436

More info at #10436 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache mentioned this pull request Feb 21, 2025
Closed
@weizhouapache
Copy link
Member Author

weizhouapache commented Feb 21, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 21, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (e196275) to head (6532246).
Report is 38 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10440   +/-   ##
=========================================
  Coverage     15.15%   15.15%           
  Complexity    11314    11314           
=========================================
  Files          5413     5413           
  Lines        474704   474704           
  Branches      57893    57893           
=========================================
  Hits          71942    71942           
  Misses       394717   394717           
  Partials       8045     8045
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but needs testing with loads of networks.

@blueorangutan
Copy link

blueorangutan commented Feb 21, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12533

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Feb 21, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 21, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 22, 2025

[SF] Trillian test result (tid-12485)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10440-t12485-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@Pearl1594 Pearl1594 linked an issue Mar 5, 2025 that may be closed by this pull request
VR: DHCP doesn't work on new instance "not using configured address ... because it is leased to ..." #10436
Closed
@weizhouapache weizhouapache marked this pull request as ready for review March 6, 2025 14:36
@weizhouapache weizhouapache added this to the 4.19.3 milestone Mar 28, 2025
@JoaoJandre
Copy link
Contributor

JoaoJandre commented Apr 9, 2025

@weizhouapache could you add some explanation on the cause of #10436 and how this PR fixes it?

Maybe I've missed it on the issue but I was not able to find it there. Without context, it is hard to judge if these changes are ok or not.

@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 9, 2025

@weizhouapache could you add some explanation on the cause of #10436 and how this PR fixes it?

Maybe I've missed it on the issue but I was not able to find it there. Without context, it is hard to judge if these changes are ok or not.

@JoaoJandre
Refer to my comment #10436 (comment)

ACS indeed tried to release the ip but the lease file was not changed.

You can test shared network with ACS 4.20

@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 17, 2025

I tried to reproduce the issue today, but failed

I am closing the PR. will re-visit later.

cc @DaanHoogland @vishesh92 @JoaoJandre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:networking component:virtual-router Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

VR: DHCP doesn't work on new instance "not using configured address ... because it is leased to ..."

4 participants

@weizhouapache @blueorangutan @DaanHoogland @JoaoJandre